Skip to content

Commit 49ad7bc

Browse files
committed
cmd/compile: note that some rules know the name of the opt pass
Change-Id: I4a70f4a52f84cf50f99939351319504b1c5dff76 Reviewed-on: https://go-review.googlesource.com/c/go/+/175777 Run-TryBot: Josh Bleecher Snyder <[email protected]> Reviewed-by: Keith Randall <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 8280455 commit 49ad7bc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/cmd/compile/internal/ssa/compile.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ var passes = [...]pass{
386386
{name: "short circuit", fn: shortcircuit},
387387
{name: "decompose args", fn: decomposeArgs, required: true},
388388
{name: "decompose user", fn: decomposeUser, required: true},
389-
{name: "opt", fn: opt, required: true}, // TODO: split required rules and optimizing rules
389+
{name: "opt", fn: opt, required: true}, // NB: some generic rules know the name of the opt pass. TODO: split required rules and optimizing rules
390390
{name: "zero arg cse", fn: zcse, required: true}, // required to merge OpSB values
391391
{name: "opt deadcode", fn: deadcode, required: true}, // remove any blocks orphaned during opt
392392
{name: "generic cse", fn: cse},

0 commit comments

Comments
 (0)