This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Add item on relative imports to FAQ #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
suggested changes
Aug 3, 2017
docs/FAQ.md
Outdated
| > i. the toolchain already frowns heavily on them<br> | ||
| > ii. it's worse for our case, as we start venturing into [dot dot hell](http://doc.cat-v.org/plan_9/4th_edition/papers/lexnames) territory when trying to prove that the import does not escape the tree of the project -[@sdboyer in #899](https://github.com/golang/dep/issues/899#issuecomment-317904001) | ||
|
|
||
| For a refresher on Go's recommended workspace organization, see https://golang.org/doc/code.html. Organizing your code this way gives you a unique import path for every package. |
There was a problem hiding this comment.
nit: let's have some text, rather than just a naked link.
There was a problem hiding this comment.
Got it! :) Will change 👍
sdboyer
approved these changes
Aug 4, 2017
|
LGTM - thanks! yay, first PR! 🎉 |
|
Yay, thanks @sdboyer! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Adds a FAQ item "Does dep support relative imports?" to docs/FAQ.md. Created in response to #910.
What should your reviewer look out for in this PR?
Clarity of explanation and correct style - I tried to follow the FAQ's standard structure by pulling an explanation from existing issue discussion and quoting the author / linking to the page.
Do you need help or clarification on anything?
Happy to make changes to this if the content needs work!
Which issue(s) does this PR fix?