Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

docs: Gopkg.toml.md version #809

Merged
merged 2 commits into from
Jul 14, 2017
Merged

docs: Gopkg.toml.md version #809

merged 2 commits into from
Jul 14, 2017

Conversation

darkowlzz
Copy link
Collaborator

What does this do / why do we need it?

Add document for version property of constraint and override.

Do you need help or clarification on anything?

Help in improving the proposed document addition.

Which issue(s) does this PR fix?

fixes #808

@darkowlzz darkowlzz requested a review from ibrasho July 13, 2017 17:24
@ibrasho
Copy link
Collaborator

ibrasho commented Jul 13, 2017

I think adding more details here and changing the FAQ answer to link to this section is better.

Internally, dep uses [Masterminds/semver](https://github.com/Masterminds/semver)
to work with semver versioning.

[Why is dep ignoreing a version constraint in the manifest?](https://github.com/golang/dep/blob/master/FAQ.md#why-is-dep-ignoring-a-version-constraint-in-the-manifest)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: ignoreing -> ignoring

@darkowlzz
Copy link
Collaborator Author

I think adding more details here and changing the FAQ answer to link to this section is better.

Yeah, that would be better. Gopkg.toml.md is more of a definition page with examples.
I have added a link to Gopkg.toml.md in FAQ's When should I use constraint, override, required, or ignored in Gopkg.toml? section. Hope that looks good. 🙂

Copy link
Collaborator

@ibrasho ibrasho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@darkowlzz darkowlzz merged commit 911cd22 into golang:master Jul 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version operator documentation missing
4 participants