This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Update the FAQ to use constraint instead of dependencies (reflect #538) #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies) [[dependencies]] was changed to [[constraint]] but the FAQ had answers that used the old field. Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho
changed the title
|
This PR complements the changes in #736. |
darkowlzz
reviewed
Jun 10, 2017
| behave differently: | ||
|
|
||
| * Dependencies: | ||
| * Constraints: |
There was a problem hiding this comment.
I thought of replacing "Dependencies" with "Constraints" around this section, but resisted thinking we might keep using "Dependencies" for direct dependencies as a reference to constraints.
👍
There was a problem hiding this comment.
Since this is in the context of explaining the diff between [constraint] and [override], I agree that it makes more sense to use the term Constraints.
carolynvs
approved these changes
Jun 11, 2017
carolynvs
suggested changes
Jun 11, 2017
FAQ.md
Outdated
| behave differently: | ||
|
|
||
| * Dependencies: | ||
| * Constraints: | ||
| 1. Can be declared by any project's manifest, yours or a dependency | ||
| 2. Apply only to direct dependencies of the project declaring the constraint | ||
| 3. Must not conflict with the `dependencies` declared in any other project's manifest |
There was a problem hiding this comment.
Oops! There's one more that needs to be updated from dependencies to [constraint]'s. Not 100% sure how to refer to the header in the plural form.
There was a problem hiding this comment.
This was updated in #736 😄
|
LGTM 😀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
[[dependencies]] was changed to [[constraint]] but the FAQ still has answers that reference the old field.
Which issue(s) does this PR fix?
Update the FAQ to use
constraintsinstead ofdependencieswhere the reference is to the manifest field.