Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Drop remove subcommand #483

Merged
merged 1 commit into from
May 30, 2017
Merged

Conversation

darkowlzz
Copy link
Collaborator

Removes remove.go along with all the test files and harness tests.

Fixes #481

@sdboyer
Copy link
Member

sdboyer commented Apr 29, 2017

easy enough, though I want to pump the breaks on this one for a second - just enough for a pass over the CLI help text to make sure there are no references to anything like this command's behavior (removing items from the manifest), either implicit or explicit.

@sdboyer
Copy link
Member

sdboyer commented May 11, 2017

Rebase for feature branch integration, please 😄

@darkowlzz darkowlzz force-pushed the 481-drop-remove-subcommand branch from 237d735 to 0a8a4d1 Compare May 11, 2017 08:28
@darkowlzz
Copy link
Collaborator Author

@sdboyer rebased onto current master :)

@sdboyer
Copy link
Member

sdboyer commented May 30, 2017

I never actually made the feature branch for this, and I'm likely not to do so, as I'd rather just merge these directly.

So...one more rebase? 😄

Removes remove.go along with all the test files and harness tests.
@darkowlzz darkowlzz force-pushed the 481-drop-remove-subcommand branch from 0a8a4d1 to abcd78e Compare May 30, 2017 11:17
@darkowlzz
Copy link
Collaborator Author

rebased! 😁

@sdboyer
Copy link
Member

sdboyer commented May 30, 2017

excellent - thank you 😄

@sdboyer sdboyer merged commit cb2c56a into golang:master May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants