add ablity to test error scenarios in test harness #317
Conversation
|
Ah nerds, that test failed the CI check ... should I wait till after the PR from @tro3 is merged and rebase my changes on that one? |
|
@domgreen, the PR I have in the queue is about being able to -update the testcase. I don't know what you mean about |
|
@tro3 Sorry, I was trying to say that is the |
|
@domgreen - two different things. The "-update PR" gives the test suite a capability to update the What I can't figure out is how your modifications could have affected that test. I get the same result on my machine - master passes, but your PR fails. I'll dig. |
|
Aha! Apparently, |
test/integration_testcase.go
Outdated
| tc.t.Errorf("expected error %s, got error %s", want, got) | ||
| } | ||
| } else if !wantExists && gotExists { | ||
| tc.t.Errorf("%s error raised where none was expected", got) |
There was a problem hiding this comment.
Fatalf should be used on line 71. If an unexpected error occurs, the rest of the test is invalid, and should just end.
Allows tests to easily read lock/manifest files from any directory, not just the testdata directory
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Closing and moving to #319 as I've obviously mess up with git ... remember to constantly rebase. |
Adding the ability to check for error scenarios in the test harness.
@tro3 - mind casting an eye over this, please.
Seems to have broken the
TestIntegration/ensure/update/case1test but think we knew that would happen, think @tro3 already has a PR out for the fix.