Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Added two lost docs Testing changes to a dependency, Changing dependencies #1677

Merged
merged 3 commits into from
Feb 12, 2018

Conversation

scriptonist
Copy link
Contributor

@scriptonist scriptonist commented Feb 12, 2018

What does this do / why do we need it?

When we migrated to our new doc site we lost the following topic:

This PR attemts to add these back to the new docs website.

What should your reviewer look out for in this PR?

  • Is the section placed at the right position in docs ?
  • Any additional information missing ?

Which issue(s) does this PR fix?

Fixes #1665

Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit and we are all set! 👍

docs/FAQ.md Outdated
@@ -107,6 +109,21 @@ behave differently:

Overrides are also discussed with some visuals in [the gps docs](https://github.com/sdboyer/gps/wiki/gps-for-Implementors#overrides).

## <a id="how-do-i-change-change-the-version-of-a-dependecy"></a> How do I change change the version of a dependecy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please remove the anchor tags? The anchor is generated from the header content and should work just fine without the anchor (like the other faq's).

@scriptonist
Copy link
Contributor Author

@carolynvs Yup. Made those changes 👍.Hope It's okay now 😄

docs/FAQ.md Outdated
@@ -12,6 +12,7 @@ The FAQ predated the introduction of the rest of the documentation. If something
## Configuration
* [What is the difference between Gopkg.toml (the "manifest") and Gopkg.lock (the "lock")?](#what-is-the-difference-between-gopkgtoml-the-manifest-and-gopkglock-the-lock)
* [How do I constrain a transitive dependency's version?](#how-do-i-constrain-a-transitive-dependency-s-version)
* [How do I change change the version of a dependecy?](#how-do-i-change-change-the-version-of-a-dependecy)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Found one more thing, sorry I didn't catch it the first time. We have a stutter "change change" in the title of this question that needs to be fixed here and in the header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. My bad, I should have double checked that.Pushed those changes, please do take a look.

Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround! :shipit:

@carolynvs carolynvs merged commit f66513f into golang:master Feb 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back lost documentation for editing a dependency locally
3 participants