internal/fs: Remove symlink cycle from testdata #1412
Conversation
Some tools get unhappy with a symlink cycle, and the test is not verifying anything related to the directory symlink being a cycle.
|
Tests were failing on macOS. I restarted the build to make sure it's not a random hiccup. I'm still not sure why this change is needed... Can you elaborate more on which tools are failing? |
|
I think it was bazel: it refused to do anything at all. I'm not at a computer right now, so can't verify. |
|
I'm attempting to vendor dep and ran into this issue (it seems like it doesn't prune the $ bazel test ...
ERROR: infinite symlink expansion detected
[start of symlink chain]
.../src/k8s.io/test-infra/vendor/github.com/golang/dep/internal/fs/testdata/symlinks/dir-symlink
.../src/k8s.io/test-infra/vendor/github.com/golang/dep/internal/fs/testdata
[end of symlink chain]
ERROR: Failed to get information about path, for vendor/github.com/golang/dep/internal/fs/testdata/symlinks/dir-symlink, skipping: Infinite symlink expansion
ERROR: Infinite symlink expansion |
|
@carolynvs the stall appears to be happening in one of the |
|
@sdboyer Nothing comes to mind, and I am unable to reproduce on my mac. Looks like these three tests are running at the same time, though I don't quite get why, since I don't have parallel tests enabled for the importers. TestBaseImporter_ImportProjects |
|
i'm gonna just do this directly (a test also has to be updated). |
|
done, in 7ca88e9 . idk what those test failures were, but they were unrelated. |
|
Many thanks @sdboyer. I'd noticed this PR in my pending list last week and was going to revisit or close. Glad it's been sorted! |
What does this do / why do we need it?
Some tools get unhappy with a symlink cycle, and the test is not
verifying anything related to the directory symlink being a cycle.
What should your reviewer look out for in this PR?
Make sure tests pass on Windows.