This repository was archived by the owner on Sep 9, 2020. It is now read-only.
gps: Insulate against .git as file #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`git ls-remote` was being run without a current working directory, which - for some versions of git - has the unfortunate side effect of still looking for a local .git in the cwd hierarchy, and failing if that .git is a file instead of a directory (as it might be if the user is working beneath a git submodule). This relocates the call to somewhere safer, under gps' control, so that we've a better (though not foolproof) guarantee of not colliding with a .git file. Fixes golang#1338.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
git ls-remotewas being run without a current working directory, which - for some versions of git - has the unfortunate side effect of still looking for a local.gitin the cwd hierarchy, and failing if that .git is a file instead of a directory (as it might be if the user is working beneath a git submodule).This relocates the call to somewhere safer, under gps' control, so that we've a better (though not foolproof) guarantee of not colliding with a
.gitfile.Which issue(s) does this PR fix?
Fixes #1338.