dep: Permit no Go source for ensure -add

[jackwilsdon]

What does this do / why do we need it?

Allows a directory to contain no Go code when running dep ensure -add

Do you need help or clarification on anything?

Is this the best way to do it? I feel like there may be a better way than setting noGoErrors to 0 - should I not increment noGoErrors if allowNoGoErrors is true? Or maybe change both of the if statements which depend on noGoErrors to check allowNoGoErrors too?

Does a new test need creating to cover this?

Which issue(s) does this PR fix?

#1312: dep ensure -add should not depend on Go code

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[jackwilsdon]

I signed it!

[googlebot]

CLAs look good, thanks!

[sdboyer]

ah, thanks for taking this on!

adding a new param is a bit of a hack, but it's not the end of the world. we definitely need a test for this, though! something under cmd/dep/testdata/harness_tests.

[sdboyer]

the only problem is the len(m) == 0 case. it's not likely to be reachable under normal circumstances - the directory Gopkg.toml is in will always be scanned, so there's always going to be at least one - but it's probably possible to hit it with ignores. so, both checks will need modification.

[jackwilsdon]

Fixed in 40f0f41.

[sdboyer]

bump - anything i can do to help this along?

[jackwilsdon]

Sorry for the delayed reply! Just came back from holiday 😎.

Just had a thought - instead of completely forgetting about the "no dirs contained any Go code" error, is it worth instead returning that as a non-fatal error?

Regarding the test case - am I best putting this in cmd/dep/testdata/harness_tests/ensure/add/errs/no-go, and copying how cmd/dep/testdata/harness_tests/ensure/pkg-errors/case1 works?

[jackwilsdon]

Just noticed that @arbourd commented on build errors also causing dep ensure -add to fail, is that something else that needs changing?

dep ensure -add won't work if the project can't build, either:

all dirs contained build errors

[mvdan]

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!