-
Notifications
You must be signed in to change notification settings - Fork 1k
panic: canary - *should* be impossible to have a pkg-only selection here #408
Comments
It is reproducible, but it is not related to the preceeding |
@jmank88 canaries are working, this is probably a bug! 😄 thanks for the issue report. Could you re-run with |
Well, it's very odd that you'd end up on that panic (and that still indicates a bug). But it seems like you shouldn't have gotten here at all; it appears that there's another bug where it's not picking up the full version list for That line is super wrong - there should be at least 40 or so more versions available to try. |
Running the current latest version of dep (commit d010781), I am experiencing similar problems running The verbose log output can be found here. FWIW, traefik also uses Let me know if I can do anything to help analyze the problem. |
I wonder if this could be related to the docker->moby name change. |
While the docker->moby name change is...well, super fun, it's unlikely to be causing the problem. GitHub redirects requests to the old name. And we can see docker/docker showing up just fine in @timoreimann's log output. To be clear, the problem here is, unequivocally, a solver bookkeeping problem. The canary panics in the solver (there are currently seven) are in place to identify situations where the solver's internal state invariants have been invalidated. This particular one could easily just be wrong, though - and the more I stare at it, the more I think it is. |
Yes, looking at it more, that panic just shouldn't be there, as it's a perfectly valid case. Will get this fixed promptly after #453 😄 |
OK, this issue should be gone - it got through a Man, does it feel good to be able to just fix something directly 😄 |
holy moly, that's what I call a quick fix (and I don't mean the bad kind)! 🚀 Thanks @sdboyer! 👏 |
There had been a canary panic in this case, but that was just incorrect. It's perfectly legitimate for a project marked for retrying to have induced some pkg-only selections. Fixes golang#408.
With latest
dep
(536f25f), runningdep init
on the latest github.com/iron-io/functions (32278fe2e02e38737fe87be32975255b81712f17) produces a panic that I don't see an open issue for.Full Log
Relevant error:
The text was updated successfully, but these errors were encountered: