Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Use upstream gps lock diff implementation #312

Closed
carolynvs opened this issue Mar 10, 2017 · 2 comments
Closed

Use upstream gps lock diff implementation #312

carolynvs opened this issue Mar 10, 2017 · 2 comments

Comments

@carolynvs
Copy link
Collaborator

From #256, I implemented lock diffing and thought it may be more appropriate to have it in the gps package. At the very least it would remove some workarounds I had to put in because of unexported fields. Though one option is to update gps to export those fields and keep the diffing in dep.

  • dep.LockDiff struct, dep.LockedProjectDiff struct, dep.StringDiff struct. These are the structures which hold the diff and are printed to the console during a dry-run.
  • dep.diffLocks(), dep.diffProjects(). The diff implementation.
  • dep.getVersionInfo(): Decomposes a gps.Version interface into the underlying metadata that is persisted in the lock file (revision, branch and version).
@carolynvs
Copy link
Collaborator Author

I've submitted a PR to gps moving LockDiff and co. Since there has been a bit of drift in the gps API and I have open PR which touches LockDiff (the TOML annotations), I'll hold off on submitting a PR to complete the move until that settles down.

@sdboyer sdboyer changed the title Move lock diff implementation into gps? Use upstream gps lock diff implementation Apr 15, 2017
@sdboyer
Copy link
Member

sdboyer commented Apr 15, 2017

Renaming and repurposing this issue as a reminder to remove what we have locally once we pull in the latest gps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants