You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 9, 2020. It is now read-only.
I recently tried migrating one of my repositories to go modules (sorry!). I had some tool dependencies and the current go modules way of declaring such are through a tools.go file with a tools build tag.
This works fine until you have someone using dep depending on a package that contains your tools.go file. It seems dep, when resolving the transitive dependencies of such a dependency, concludes that these tool dependencies are also part of the graph. I think this is incorrect behaviour.
I propose that dep should ignore files that use the build tag tools.
johanbrandhorst
changed the title
Dep should ignore packages only imported in files with ignore build tag
Dep should ignore packages only imported in files with tools build tag
Feb 23, 2019
I made a mistake in the original post, I thought ignore was the build tag used, but it is not. The tag used is tools. I realize this greatly weakens the argument.
Hi!
I recently tried migrating one of my repositories to
go modules
(sorry!). I had some tool dependencies and the currentgo modules
way of declaring such are through atools.go
file with atools
build tag.This works fine until you have someone using
dep
depending on a package that contains yourtools.go
file. It seemsdep
, when resolving the transitive dependencies of such a dependency, concludes that these tool dependencies are also part of the graph. I think this is incorrect behaviour.I propose that
dep
should ignore files that use the build tagtools
.Related issue: #463.
My repo with the problematic transative import behaviour: johanbrandhorst/certify#48.
The text was updated successfully, but these errors were encountered: