Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Replace versionInWorkspace() stub #21

Closed
sdboyer opened this issue Dec 2, 2016 · 1 comment · Fixed by #27
Closed

Replace versionInWorkspace() stub #21

sdboyer opened this issue Dec 2, 2016 · 1 comment · Fixed by #27
Assignees

Comments

@sdboyer
Copy link
Member

sdboyer commented Dec 2, 2016

In #18, we introduced a versionInWorkspace() stub function that is supposed to inspect a GOPATH workspace and determine the version of a provided project root. Right now, we've just hardcoded versions for the dep tool's own external deps, but this needs to be actually addressed.

@freeformz said he might be able to take a stab at this, so I'm assigning him.

@sdboyer
Copy link
Member Author

sdboyer commented Dec 2, 2016

I do have one note to raise...

@freeformz, when you mentioned that you had some existing code to do stuff like this in godep, the thought occurred to me that gps already relies on Masterminds/vcs for its basic repo interactions. That lib isn't perfect (what is), but I am a little worried about having different vcs interaction layers used in different parts of the program. Then again, if we generally agree that's unwise in the long term, then I also don't really want to block progress - I think it might be OK to pull in what you have so that we have this problem solved, with the intention that we refactor later?

@sdboyer sdboyer mentioned this issue Dec 3, 2016
2 tasks
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants