Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

remove the "cute" error messages #151

Closed
rakyll opened this issue Jan 25, 2017 · 4 comments
Closed

remove the "cute" error messages #151

rakyll opened this issue Jan 25, 2017 · 4 comments

Comments

@rakyll
Copy link
Contributor

rakyll commented Jan 25, 2017

fmt.Printf("ouchie, solve error: %s", err)

Go tools have a specific tone and style (simple comprehensive and precise), hence we don't see them return errors in such an unlikely style. Follow the Go tool conventions, please. This is a candidate to be an official tool.

@sdboyer
Copy link
Member

sdboyer commented Jan 25, 2017

Oh, of course. The places where we don't follow that convention, like the one you've cited, exist more or less because it gives the clear indication that it's an area that is unfinished. There's no way we'd let them into the final tool. (let's not forget - pre-alpha!)

@rakyll
Copy link
Contributor Author

rakyll commented Jan 25, 2017

I can sign up to fix these as I see.

It is good to align with the Go project as soon as possible to making the blessing of this tool or reusing of its code easier if succeeds. It'd be a shame if we had to re-rewrite this tool.

@rakyll rakyll changed the title Remove cute error messages remove the "cute" error messages Jan 25, 2017
@sdboyer
Copy link
Member

sdboyer commented Jan 25, 2017

I can sign up to fix these as I see.

🎉 🎉

so long as there's a clear TODO (or equivalent) left behind, i'm all 👍 to that.

It is good to align with the Go project as soon as possible to making the blessing of this tool or reusing of its code easier if succeeds. It'd be a shame if we had to re-rewrite this tool.

for sure. and, like i noted elsewhere (too many issues flying around right now), this is something that just gets harder as time goes on.

tbh, i'm less concerned about that for this tool than i am for gps. i've put a lot more deliberate effort into it than the parts of dep i've written (which has generally been written with a more experiment/prototyping mindset). still, though, there's likely plenty of style/convention things that i've missed, because i haven't spent the time acculturating to how core reviewers do things.

hloeffler added a commit to hloeffler/dep that referenced this issue Jan 30, 2017
adg pushed a commit that referenced this issue Jan 30, 2017
zbintliff added a commit to zbintliff/dep that referenced this issue Mar 3, 2017
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
Fixes golang#151.

♬ : Anna Kendrick / Cups (Pitch Perfect’s “When I’m Gone”)
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
ibrasho pushed a commit to ibrasho-forks/dep that referenced this issue May 10, 2017
@sdboyer
Copy link
Member

sdboyer commented Aug 10, 2017

i think these are pretty much gone now - closing

@sdboyer sdboyer closed this as completed Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants