Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

add a Makefile? #133

Closed
kevinburke opened this issue Jan 24, 2017 · 3 comments
Closed

add a Makefile? #133

kevinburke opened this issue Jan 24, 2017 · 3 comments

Comments

@kevinburke
Copy link
Collaborator

The test tool people might be used to running (go test ./...) both iterates over the vendor directory and is slow (98 seconds on my machine).

maybe we could add some targets for e.g. make test, make race-test, make unit, make vet to tell people how to run the tests in various circumstances? Also could use those targets in the .travis.yml file.

@jessfraz
Copy link
Contributor

hahha I tried this: #51

but to be honest the go team seems to be pretty against makefiles and running tests is as easy as go test w no args same goes for install and build so i dont really see an issue

@kevinburke
Copy link
Collaborator Author

kevinburke commented Jan 24, 2017

OK

@carolynvs
Copy link
Collaborator

I use an uncommitted Makefile so that I don't forget key steps before submitting a PR. I may not be the only contributor who would appreciate a single command to validate their branch before making making preventable mistakes (like forgetting to run go fmt or adding a new test file without a license at the top).

krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants