node_modules with go code causing `dep ensure` to error

[conner]

What version of Go (go version) and dep (git describe --tags) are you using?

go version go1.8.3 darwin/amd64 / v0.3.0-147-gedc545f

What dep command did you run?

dep ensure

What did you expect to see?

...

What did you see instead?

Found 1 errors:

import path github.com/user/project/node_modules/grpc/third_party/boringssl/ssl/test/runner had local imports: "./curve25519\", \"./newhope\", \"./poly1305"

Description

We've got a gRPC javascript client (and its node_modules including grpc) co-homed with our server that has dependencies managed by dep. It looks like a change to gps introduced this issue we're seeing.

(a working SHA compared with the current one)
42374f1...edc545f

[ibrasho]

Could you try the code from #997? It should solve your issue.

[conner]

Fixed in #997 - You can see the issue in the verbose log, but execution continues

[conner]

I still think I should be able to tell dep not to look at node_modules ... right? (.depignore? : )

[ibrasho]

#997 is merged now. :-)

[ibrasho]

Closing this for the moment. I remember seeing a discussion about being able to define skipped files in another issue, but if you think it's worth its own, please go ahead and open a dedicated issue for that. 👍