Skip to content

Commit bcf6a84

Browse files
committed
acme: pass context to request
Fixes golang/go#30183 Change-Id: Ic02b34bc87b9465f5c05b2ef5bec157c58809a91 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/719002 Reviewed-by: Junyang Shao <[email protected]> Reviewed-by: Daniel McCarney <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent b4f2b62 commit bcf6a84

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

acme/acme.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,7 @@ func (c *Client) addNonce(h http.Header) {
690690
}
691691

692692
func (c *Client) fetchNonce(ctx context.Context, url string) (string, error) {
693-
r, err := http.NewRequest("HEAD", url, nil)
693+
r, err := http.NewRequestWithContext(ctx, "HEAD", url, nil)
694694
if err != nil {
695695
return "", err
696696
}

acme/http.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func wantStatus(codes ...int) resOkay {
128128
func (c *Client) get(ctx context.Context, url string, ok resOkay) (*http.Response, error) {
129129
retry := c.retryTimer()
130130
for {
131-
req, err := http.NewRequest("GET", url, nil)
131+
req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
132132
if err != nil {
133133
return nil, err
134134
}
@@ -228,7 +228,7 @@ func (c *Client) postNoRetry(ctx context.Context, key crypto.Signer, url string,
228228
if err != nil {
229229
return nil, nil, err
230230
}
231-
req, err := http.NewRequest("POST", url, bytes.NewReader(b))
231+
req, err := http.NewRequestWithContext(ctx, "POST", url, bytes.NewReader(b))
232232
if err != nil {
233233
return nil, nil, err
234234
}

0 commit comments

Comments
 (0)