x/build/cmd/gopherbot: add has-cl label to issues with CL #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

leighmcculloch wants to merge 1 commit into golang:master from leighmcculloch:add-has-cl-label

leighmcculloch commented Jul 20, 2018 •

edited

Loading

For contributors looking for new issues to contribute to it can be
difficult to find issues that need a fix and don't already have a fix
being considered. There are several labels that help guide the way
already, like NeedsFix, HelpWanted. But many issues with this label will
already have a CL. There's currently no way to identify with a GitHub
search which issues have CLs and which do not. It'd be helpful to be
able to search for issues that do not have a CL and a label on issues
that have a CL is a simple method to distinguishing issues that do or do
not have a CL.

Fixes golang/go#26494

googlebot added the cla: yes label

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 5065:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 5065:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!


          cmd/gopherbot: add has-cl label to issues with CL

6f4d935

For contributors looking for new issues to contribute to it can be
difficult to find issues that need a fix and don't already have a fix
being considered. There are several labels that help guide the way
already, like NeedsFix, HelpWanted. But many issues with this label will
already have a CL. There's currently no way to identify with a GitHub
search which issues have CLs and which do not. It'd be helpful to be
able to search for issues that do not have a CL and a label on issues
that have a CL is a simple method to distinguishing issues that do or do
not have a CL.

Fixes #26494

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 21426:

Patch Set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 12446:

Uploaded patch set 6: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 21426:

Patch Set 7: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 12446:

Uploaded patch set 8: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 21426:

Patch Set 8:

(3 comments)

Thanks for the feedback Brad! I've addressed each concern.

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

leighmcculloch changed the title ~~x/build/cmd/gopherbot: Add HasCL label to issues with CL~~ x/build/cmd/gopherbot: add has-cl label to issues with CL

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 12446:

Uploaded patch set 9: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/125196.
After addressing review feedback, remember to publish your drafts!

Author

leighmcculloch commented Jul 21, 2018

Closing this PR because of @andybons comment here golang/go#26494 (comment).

leighmcculloch closed this

leighmcculloch deleted the add-has-cl-label branch

July 21, 2018 01:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels