Skip to content

Commit d719d26

Browse files
committed
cmd/release: run all.bash when constructing releases
This ensures that each release actually passes the tests. Fixes golang/go#11943 Change-Id: Ia7bb34a611389fe0d529bdb76ff4d0cd68d3d7cd Reviewed-on: https://go-review.googlesource.com/12914 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent ca5899f commit d719d26

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

cmd/release/release.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5+
// TODO(adg): add flag so that we can choose to run make.bash only
6+
57
// Command release builds a Go release.
68
package main
79

@@ -286,10 +288,11 @@ func (b *Build) make() error {
286288
// Execute build
287289
b.logf("Building.")
288290
out := new(bytes.Buffer)
289-
mk := filepath.Join(goDir, bc.MakeScript())
290-
remoteErr, err := client.Exec(mk, buildlet.ExecOpts{
291+
all := filepath.Join(goDir, bc.AllScript())
292+
remoteErr, err := client.Exec(all, buildlet.ExecOpts{
291293
Output: out,
292294
ExtraEnv: env,
295+
Args: bc.AllScriptArgs(),
293296
})
294297
if err != nil {
295298
return err

0 commit comments

Comments
 (0)