dashboard,env/freebsd: add 12.3-STABLE

With the XSAVE bug fix.

For golang/go#49967, golang/go#46272.

Change-Id: Ie0711ba83e4f15d26e6fe89e89c80b7c3ad2c23c
Reviewed-on: https://go-review.googlesource.com/c/build/+/375695
Trust: Heschi Kreinick <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Author: heschi

dashboard/builders.go

@@ -351,6 +351,14 @@ var Hosts = map[string]*HostConfig{
 		goBootstrapURLTmpl: "https://storage.googleapis.com/$BUCKET/go1.4-freebsd-amd64.tar.gz",
 		SSHUsername:        "gopher",
 	},
+	"host-freebsd-12_3": &HostConfig{
+		VMImage:            "freebsd-amd64-123-stable-20211230",
+		Notes:              "FreeBSD 12.3; GCE VM is built from script in build/env/freebsd-amd64",
+		machineType:        "e2-highcpu-4",
+		buildletURLTmpl:    "https://storage.googleapis.com/$BUCKET/buildlet.freebsd-amd64",
+		goBootstrapURLTmpl: "https://storage.googleapis.com/$BUCKET/go1.4-freebsd-amd64.tar.gz",
+		SSHUsername:        "gopher",
+	},
 	"host-freebsd-13_0": &HostConfig{
 		VMImage:            "freebsd-amd64-130-stable-20211230",
 		Notes:              "FreeBSD 13.0; GCE VM is built from script in build/env/freebsd-amd64",
@@ -1574,13 +1582,28 @@ func init() {
 		distTestAdjust:    fasterTrybots, // If changing this policy, update TestShouldRunDistTest accordingly.
 		numTryTestHelpers: 4,
 	})
+	addBuilder(BuildConfig{
+		Name:     "freebsd-amd64-12_3",
+		HostType: "host-freebsd-12_3",
+		tryBot:   defaultTrySet("sys"),
+
+		distTestAdjust:    fasterTrybots, // If changing this policy, update TestShouldRunDistTest accordingly.
+		numTryTestHelpers: 4,
+	})
 	addBuilder(BuildConfig{
 		Name:              "freebsd-386-12_2",
 		HostType:          "host-freebsd-12_2",
 		env:               []string{"GOARCH=386", "GOHOSTARCH=386"},
 		distTestAdjust:    fasterTrybots,
 		numTryTestHelpers: 4,
 	})
+	addBuilder(BuildConfig{
+		Name:              "freebsd-386-12_3",
+		HostType:          "host-freebsd-12_3",
+		env:               []string{"GOARCH=386", "GOHOSTARCH=386"},
+		distTestAdjust:    fasterTrybots,
+		numTryTestHelpers: 4,
+	})
 	addBuilder(BuildConfig{
 		Name:     "freebsd-amd64-race",
 		HostType: "host-freebsd-13_0-big",

dashboard/builders_test.go

@@ -93,6 +93,7 @@ func TestTrybots(t *testing.T) {
 			want: []string{
 				"android-amd64-emu",
 				"freebsd-amd64-12_2",
+				"freebsd-amd64-12_3",
 				"js-wasm",
 				"linux-386",
 				"linux-amd64",
@@ -128,6 +129,7 @@ func TestTrybots(t *testing.T) {
 			want: []string{
 				"android-amd64-emu",
 				"freebsd-amd64-12_2",
+				"freebsd-amd64-12_3",
 				"js-wasm",
 				"linux-386",
 				"linux-amd64",
@@ -163,6 +165,7 @@ func TestTrybots(t *testing.T) {
 			want: []string{
 				"android-amd64-emu",
 				"freebsd-amd64-12_2",
+				"freebsd-amd64-12_3",
 				"js-wasm",
 				"linux-386",
 				"linux-amd64",
@@ -200,6 +203,7 @@ func TestTrybots(t *testing.T) {
 			want: []string{
 				"android-amd64-emu",
 				"freebsd-amd64-12_2",
+				"freebsd-amd64-12_3",
 				"js-wasm",
 				"linux-386",
 				"linux-amd64",
@@ -247,6 +251,7 @@ func TestTrybots(t *testing.T) {
 				"freebsd-386-13_0",
 				"freebsd-amd64-11_4",
 				"freebsd-amd64-12_2",
+				"freebsd-amd64-12_3",
 				"freebsd-amd64-13_0",
 				"linux-386",
 				"linux-amd64",

env/freebsd-amd64/make.bash

@@ -80,6 +80,12 @@ case $1 in
   readonly VERSION_TRAILER=
   readonly SHA256=0f8593382b6833658c6f6be532d4ffbedde7b75504452e27d912a0183f72ab56
 ;;
+12.3-SNAPSHOT)
+  readonly IS_SNAPSHOT=1
+  readonly VERSION=12.3-STABLE
+  readonly VERSION_TRAILER=
+  readonly SHA256=e52ddb31b8f2ff7f8d03571b65e472cde3f92ef6b73ddaa5e7f5d4668ce4394c # https://lists.freebsd.org/archives/freebsd-snapshots/2021-December/000037.html
+;;
 13.0)
   readonly VERSION=13.0-RELEASE
   readonly VERSION_TRAILER=
@@ -89,7 +95,7 @@ case $1 in
 13.0-SNAPSHOT)
   readonly IS_SNAPSHOT=1
   readonly VERSION=13.0-STABLE
-  readonly VERSION_TRAILER="-20211230-3684bb89d52-248759"
+  readonly VERSION_TRAILER=
   readonly SHA256=7b8fcc2330c8d9f66dd012c5859167d56c227ece39188c8f55b2bddbf688875f # https://lists.freebsd.org/archives/freebsd-snapshots/2021-December/000036.html
   readonly BLIND_SWITCH_CONSOLE=1
 ;;