Skip to content

Commit 253aa5b

Browse files
dmitshurgopherbot
authored andcommitted
cmd/coordinator: display LUCI build results on build dashboards (part 2)
This makes the new view on by default. As before, it remains possible to opt-out via a 'legacyonly=1' URL query parameter. For golang/go#65913. Change-Id: I52b0a7e206a1d8bdf4645d4e1f91cadebb446c0e Reviewed-on: https://go-review.googlesource.com/c/build/+/568195 Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
1 parent 8eaaf2a commit 253aa5b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cmd/coordinator/internal/dashboard/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ type Handler struct {
6363
}
6464

6565
func (d *Handler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
66-
showLUCI, _ := strconv.ParseBool(req.URL.Query().Get("showluci"))
66+
var showLUCI = true
6767
if legacyOnly, _ := strconv.ParseBool(req.URL.Query().Get("legacyonly")); legacyOnly {
6868
showLUCI = false
6969
}

cmd/coordinator/internal/legacydash/ui.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ func viewForRequest(r *http.Request) (dashboardView, error) {
102102
case "json":
103103
return jsonView{}, nil
104104
case "":
105-
showLUCI, _ := strconv.ParseBool(r.URL.Query().Get("showluci"))
105+
var showLUCI = true
106106
if legacyOnly, _ := strconv.ParseBool(r.URL.Query().Get("legacyonly")); legacyOnly {
107107
showLUCI = false
108108
}

0 commit comments

Comments
 (0)