Skip to content

Commit 8eaaf2a

Browse files
dmitshurgopherbot
authored andcommitted
cmd/coordinator: display LUCI build results on build dashboards (part 1)
This connects the pieces together, enabling the new behavior. It can be opted-out via a 'legacyonly=1' URL query parameter. In part 1 (this commit), show the old build.golang.org/ view by default. Part 2 (next commit) flips the default. For golang/go#65913. Change-Id: I04be3b9d345b97892bb18751bf8bd717481235de Reviewed-on: https://go-review.googlesource.com/c/build/+/567578 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 79dd4f3 commit 8eaaf2a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

cmd/coordinator/coordinator.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import (
4141
"golang.org/x/build/buildlet"
4242
builddash "golang.org/x/build/cmd/coordinator/internal/dashboard"
4343
"golang.org/x/build/cmd/coordinator/internal/legacydash"
44+
"golang.org/x/build/cmd/coordinator/internal/lucipoll"
4445
"golang.org/x/build/cmd/coordinator/protos"
4546
"golang.org/x/build/dashboard"
4647
"golang.org/x/build/gerrit"
@@ -360,8 +361,9 @@ func main() {
360361
// grpcServer is a shared gRPC server. It is global, as it needs to be used in places that aren't factored otherwise.
361362
grpcServer := grpc.NewServer(opts...)
362363

363-
dashV1 := legacydash.Handler(gce.GoDSClient(), maintnerClient, nil, string(masterKey()), grpcServer)
364-
dashV2 := &builddash.Handler{Datastore: gce.GoDSClient(), Maintner: maintnerClient}
364+
luciPoll := lucipoll.NewService(maintnerClient)
365+
dashV1 := legacydash.Handler(gce.GoDSClient(), maintnerClient, luciPoll, string(masterKey()), grpcServer)
366+
dashV2 := &builddash.Handler{Datastore: gce.GoDSClient(), Maintner: maintnerClient, LUCI: luciPoll}
365367
gs := &gRPCServer{dashboardURL: "https://build.golang.org"}
366368
setSessionPool(sp)
367369
gomoteServer := gomote.New(sp, sched, sshCA, gomoteBucket, mustStorageClient())

0 commit comments

Comments
 (0)