dashboard, env/linux-x86-nacl: remove nacl builders and supporting files

Go 1.13 was the last release with nacl, and it's not supported by now.

For golang/go#30439.

Change-Id: Ic690aa388ab4505d5e755bbe40fed850a7300c69
Reviewed-on: https://go-review.googlesource.com/c/build/+/260200
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>

Author: dmitshur

cmd/coordinator/coordinator.go

@@ -450,7 +450,7 @@ func stagingClusterBuilders() map[string]*dashboard.BuildConfig {
 		"linux-amd64",
 		"linux-amd64-sid",
 		"linux-amd64-clang",
-		"nacl-amd64p32",
+		"js-wasm",
 	} {
 		if c, ok := dashboard.Builders[name]; ok {
 			m[name] = c
@@ -2962,7 +2962,7 @@ var errBuildletsGone = errors.New("runTests: dist test failed: all buildlets had
 
 // runTests is only called for builders which support a split make/run
 // (should be everything, at least soon). Currently (2015-05-27) iOS
-// and Android and Nacl do not.
+// and Android do not.
 //
 // After runTests completes, the caller must assume that st.bc might be invalid
 // (It's possible that only one of the helper buildlets survived).

dashboard/builders.go

@@ -27,22 +27,19 @@ var slowBotAliases = map[string]string{
 	// Known missing builders:
 	"openbsd-arm":   "",
 	"openbsd-arm64": "",
-	"nacl-arm":      "",
 	"darwin-arm":    "", // TODO(golang.org/issue/37611): Remove once port is removed.
 	"darwin-arm64":  "", // TODO(golang.org/issue/39782): Add builder for darwin/arm64.
 
 	"386":            "linux-386",
 	"aix":            "aix-ppc64",
 	"amd64":          "linux-amd64",
-	"amd64p32":       "nacl-amd64p32",
 	"android":        "android-amd64-emu",
 	"android-386":    "android-386-emu",
 	"android-amd64":  "android-amd64-emu",
 	"android-arm":    "android-arm-corellium",
 	"android-arm64":  "android-arm64-corellium",
 	"arm":            "linux-arm",
 	"arm64":          "linux-arm64-packet",
-	"arm64p32":       "nacl-amd64p32",
 	"darwin":         "darwin-amd64-10_14",
 	"darwin-386":     "darwin-386-10_14", // TODO(golang.org/issue/37610): Remove when Go 1.14 is no longer supported.
 	"darwin-amd64":   "darwin-amd64-10_14",
@@ -73,9 +70,6 @@ var slowBotAliases = map[string]string{
 	"mips64":         "linux-mips64-rtrk",
 	"mips64le":       "linux-mips64le-mengzhuo",
 	"mipsle":         "linux-mipsle-rtrk",
-	"nacl":           "nacl-amd64p32",
-	"nacl-387":       "nacl-386",
-	"nacl-arm64p32":  "nacl-amd64p32",
 	"netbsd":         "netbsd-amd64-9_0",
 	"netbsd-386":     "netbsd-386-9_0",
 	"netbsd-amd64":   "netbsd-amd64-9_0",
@@ -157,12 +151,6 @@ var Hosts = map[string]*HostConfig{
 		Notes:       "for localhost development of buildlets/gomote/coordinator only",
 		SSHUsername: os.Getenv("USER"),
 	},
-	"host-nacl": &HostConfig{
-		Notes:           "Container with Native Client binaries.",
-		ContainerImage:  "linux-x86-nacl:latest",
-		buildletURLTmpl: "http://storage.googleapis.com/$BUCKET/buildlet.linux-amd64",
-		env:             []string{"GOROOT_BOOTSTRAP=/go1.4"},
-	},
 	"host-js-wasm": &HostConfig{
 		Notes:           "Container with node.js for testing js/wasm.",
 		ContainerImage:  "js-wasm:latest",
@@ -1060,9 +1048,6 @@ func (c *BuildConfig) AllScript() string {
 	if strings.HasPrefix(c.Name, "plan9-") {
 		return "src/all.rc"
 	}
-	if strings.HasPrefix(c.Name, "nacl-") {
-		return "src/nacltest.bash"
-	}
 	if strings.HasPrefix(c.Name, "misc-compile") {
 		return "src/buildall.bash"
 	}
@@ -1079,8 +1064,7 @@ func (c *BuildConfig) SplitMakeRun() bool {
 	switch c.AllScript() {
 	case "src/all.bash", "src/all.bat",
 		"src/race.bash", "src/race.bat",
-		"src/all.rc",
-		"src/nacltest.bash":
+		"src/all.rc":
 		// These we've verified to work.
 		return true
 	}
@@ -1254,9 +1238,6 @@ func (c *BuildConfig) MakeScript() string {
 	if strings.HasPrefix(c.Name, "plan9-") {
 		return "src/make.rc"
 	}
-	if strings.HasPrefix(c.Name, "nacl-") {
-		return "src/naclmake.bash"
-	}
 	return "src/make.bash"
 }
 
@@ -1814,29 +1795,6 @@ func init() {
 			return run
 		},
 	})
-	addBuilder(BuildConfig{
-		Name:     "nacl-386",
-		HostType: "host-nacl",
-		buildsRepo: func(repo, branch, goBranch string) bool {
-			// nacl support is removed in Go 1.14.
-			// TODO: Remove builder after Go 1.15 is out.
-			return repo == "go" && !atLeastGo1(goBranch, 14) && !strings.HasPrefix(goBranch, "dev.")
-		},
-		numTryTestHelpers: 3,
-		env:               []string{"GOOS=nacl", "GOARCH=386", "GOHOSTOS=linux", "GOHOSTARCH=amd64"},
-	})
-	addBuilder(BuildConfig{
-		Name:     "nacl-amd64p32",
-		HostType: "host-nacl",
-		buildsRepo: func(repo, branch, goBranch string) bool {
-			// nacl support is removed in Go 1.14.
-			// TODO: Remove builder after Go 1.15 is out.
-			return repo == "go" && !atLeastGo1(goBranch, 14) && !strings.HasPrefix(goBranch, "dev.")
-		},
-		tryBot:            explicitTrySet("go"),
-		numTryTestHelpers: 3,
-		env:               []string{"GOOS=nacl", "GOARCH=amd64p32", "GOHOSTOS=linux", "GOHOSTARCH=amd64"},
-	})
 	addBuilder(BuildConfig{
 		Name:     "js-wasm",
 		HostType: "host-js-wasm",

dashboard/builders_test.go

@@ -420,17 +420,6 @@ func TestBuilderConfig(t *testing.T) {
 		{b("android-amd64-emu", "go"), isBuilder},
 		{b("android-386-emu", "go"), isBuilder},
 
-		// golang.org/doc/go1.13: "Go 1.13 is the last release
-		// that will run on Native Client (NaCl)."
-		{b("nacl-386", "go"), none},
-		{b("[email protected]", "go"), none},
-		{b("[email protected]", "go"), onlyPost},
-		{b("nacl-386", "net"), none},
-		{b("nacl-amd64p32", "go"), none},
-		{b("[email protected]", "go"), none},
-		{b("[email protected]", "go"), both},
-		{b("nacl-amd64p32", "net"), none},
-
 		// Only test tip for js/wasm, and only for some repos:
 		{b("js-wasm", "go"), both},
 		{b("js-wasm", "arch"), onlyPost},