dashboard: add a map for hiding builders that migrated to LUCI

This sets a path forward for hiding builders that have migrated.
Outright deleting their configuration is left for a later phase.

For golang/go#65913.
Updates golang/go#63471.

Change-Id: Icaa40cbaf5e9395ef6f82fc70a6febc2ec8bc838
Reviewed-on: https://go-review.googlesource.com/c/build/+/568196
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>

Author: dmitshur

cmd/coordinator/internal/dashboard/handler.go

@@ -128,6 +128,11 @@ func (d *Handler) getBuilders(conf map[string]*dashboard.BuildConfig, luci lucip
 		if !b.BuildsRepoPostSubmit("go", "master", "master") {
 			continue
 		}
+		if dashboard.BuildersPortedToLUCI[b.Name] && len(luci.Builders) > 0 {
+			// Don't display old builders that have been ported
+			// to LUCI if willing to show LUCI builders as well.
+			continue
+		}
 		db := bm[b.GOOS()]
 		db.OS = b.GOOS()
 		db.Archs = append(db.Archs, &arch{

cmd/coordinator/internal/legacydash/ui.go

@@ -476,6 +476,15 @@ func (tb *uiTemplateDataBuilder) buildTemplateData(ctx context.Context, datastor
 			for _, pkg := range ts.Packages {
 				addBuilders(builders, pkg.Package.Name, ts.Branch())
 			}
+			if len(luci.Builders) > 0 {
+				for name := range builders {
+					if dashboard.BuildersPortedToLUCI[name] {
+						// Don't display old builders that have been ported
+						// to LUCI if willing to show LUCI builders as well.
+						delete(builders, name)
+					}
+				}
+			}
 			addLUCIBuilders(luci, builders, ts.Packages, gorel.BranchName)
 			ts.Builders = builderKeys(builders)
 
@@ -510,6 +519,15 @@ func (tb *uiTemplateDataBuilder) buildTemplateData(ctx context.Context, datastor
 	} else {
 		addBuilders(builders, tb.repoGerritProj(), tb.branch())
 	}
+	if len(luci.Builders) > 0 {
+		for name := range builders {
+			if dashboard.BuildersPortedToLUCI[name] {
+				// Don't display old builders that have been ported
+				// to LUCI if willing to show LUCI builders as well.
+				delete(builders, name)
+			}
+		}
+	}
 	data.Builders = builderKeys(builders)
 
 	if tb.res.CommitsTruncated {

dashboard/builders.go

@@ -2863,6 +2863,24 @@ func init() {
 	})
 }
 
+// BuildersPortedToLUCI lists coordinator builders that have been ported
+// over to LUCI and don't need to continue to run. Their results will be
+// hidden from the build.golang.org page and new builds won't be started
+// if stopPortedBuilders (below) is true.
+//
+// See go.dev/issue/65913
+// and go.dev/issue/63471.
+var BuildersPortedToLUCI = map[string]bool{
+	"wasip1-wasm-wasmedge": true, // Would be 'wasip1-wasm_wasmedge' but put off until go.dev/issue/60097 picks up activity.
+
+	// TODO(go.dev/issue/63471): Add more here. For example:
+	//"wasip1-wasm-wazero": true, // Available as https://ci.chromium.org/p/golang/builders/ci/gotip-wasip1-wasm_wazero.
+}
+
+// stopPortedBuilders controls whether ported builders should be stopped,
+// instead of just made invisible in the web UI.
+const stopPortedBuilders = false
+
 // addBuilder adds c to the Builders map after doing some checks.
 func addBuilder(c BuildConfig) {
 	if c.Name == "" {
@@ -2899,6 +2917,10 @@ func addBuilder(c BuildConfig) {
 		panic(fmt.Sprintf("build config %q host type inconsistent (must be Reverse, Image, or VM)", c.Name))
 	}
 
+	if BuildersPortedToLUCI[c.Name] && stopPortedBuilders {
+		return
+	}
+
 	Builders[c.Name] = &c
 }