x86asm: add support for FLDZ and FLDLN2

[mewmew]

Fixes golang/go#18665.

[gopherbot]

This PR (HEAD: 5603d0e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/arch/+/149438 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Cherry Zhang:

Patch Set 1:

(1 comment)

Thanks for the CL. Could we add a test?

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/149438.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from foo bar:

Patch Set 1:

Patch Set 1:

(1 comment)

Thanks for the CL. Could we add a test?

Hi Cherry!

Sure, I could add a test.

However, based on @quasilyte comment in golang/go#18665 (comment) it seems this may be the wrong approach for adding support for FLDZ and FLDLN2.

Inlining @quasilyte's comment below:

I'm not sure editing auto-generated file is a good idea though
and it doesn't solve the problem with other missing instructions in the x86.csv.
This discussion can be continued in a CL itself.

Kindly,
Robin

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/149438.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 97cdbbe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/arch/+/149438 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: fa98ffe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/arch/+/149438 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from foo bar:

Patch Set 3:

Patch Set 1:

(1 comment)

Thanks for the CL. Could we add a test?

I've now rebased this CL on top of master and added test cases for fldz and fldln2, both of which are passing.

Is there anything else needed before merging this?

Cheers,
Robin

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/149438.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Cherry Zhang:

Patch Set 3: Run-TryBot+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/149438.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=174c7efd

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/149438.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 3: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/149438.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/149438 has been merged.