Skip to content

Revert "Add io/fs#FS Driver #471" #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2020
Merged

Revert "Add io/fs#FS Driver #471" #481

merged 1 commit into from
Nov 22, 2020

Conversation

johejo
Copy link
Contributor

@johejo johejo commented Nov 21, 2020

Reverts #472

closes #480

@coveralls
Copy link

coveralls commented Nov 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 934

  • 9 of 12 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 55.205%
Changes Missing Coverage Covered Lines Changed/Added Lines %
source/file/file.go 9 12 75.0%
Totals Coverage Status
Change from base Build 932: -0.01%
Covered Lines: 3044
Relevant Lines: 5514
💛 - Coveralls

@dhui dhui merged commit b690b78 into golang-migrate:master Nov 22, 2020
@dhui
Copy link
Member

dhui commented Nov 22, 2020

Thanks for the quick fix!

@dhui dhui mentioned this pull request Nov 24, 2020
Closed
dhui added a commit to dhui/migrate that referenced this pull request May 10, 2021
@dhui
Revert "Merge pull request golang-migrate#481 from johejo/revert-472-…
337ff63 
…iofs_source_driver"

This reverts commit b690b78, reversing
changes made to 1593164.
@dhui dhui mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"package io/fs is not in GOROOT" on Go 1.15
3 participants
@johejo @coveralls @dhui