Skip to content

postgres: Make ensureVersionTable atomic #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

tsenart
Copy link
Contributor

@tsenart tsenart commented Jan 11, 2019

Fixes #55.

@tsenart
Copy link
Contributor Author

tsenart commented Jan 11, 2019

As you can see in this build log, this test reproduces what we see in #55 and https://github.com/sourcegraph/sourcegraph/issues/1491.

I'm proposing a fix here which I'm not 100% sure about. Please advise.

@tsenart tsenart changed the title [WIP] postgres: TestWithInstance_Concurrent postgres: Make ensureVersionTable atomic Jan 11, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 267

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.188%

Totals Coverage Status
Change from base Build 264: 0.0%
Covered Lines: 773
Relevant Lines: 1306

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jan 11, 2019

Pull Request Test Coverage Report for Build 267

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.188%

Totals Coverage Status
Change from base Build 264: 0.0%
Covered Lines: 773
Relevant Lines: 1306

💛 - Coveralls

@tsenart
Copy link
Contributor Author

tsenart commented Jan 11, 2019

Closing to re-open from a branch in my fork. I need the master branch to rename the import paths so that we can use the fork in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants