Use Go strings instead of C.CString #252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can define all C strings passed from Go to C as good all Go constant strings casted on demand using
unsafe.StringData
, which is almost no-op.My main motivation here is to eliminate all
C.CString
calls, as they have some small performance penalty (2 cgo calls, one forC.CString
itself and the other for the companionC.free
) and it is easy to forget callingC.free
after.A nice side-effect is that now string global variables can be statically initialized by the linker thanks to them being constant strings. This will result in faster initialization times.