Skip to content

Fix bad parsing for some .gitmodules that path and url not ordered #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

varphone
Copy link
Contributor

@varphone varphone commented Sep 2, 2020

for example, the .gitmodules in https://git.zx2c4.com/cgit is like this:

[submodule "git"]
	url = https://git.kernel.org/pub/scm/git/git.git
	path = git

for example, the .gitmodules in https://git.zx2c4.com/cgit is like this:

```.gitmodules
[submodule "git"]
	url = https://git.kernel.org/pub/scm/git/git.git
	path = git
```
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon merged commit 0bb10af into gogs:master Sep 3, 2020
@unknwon
Copy link
Member

unknwon commented Sep 3, 2020

https://github.com/gogs/git-module/releases/tag/v1.1.3 has been tagged for this merge.

@varphone varphone deleted the hotfix/fix-gitmodules-parse branch September 4, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants