Skip to content

Add supports to context.Context #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Add supports to context.Context #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4a1123b
add context support
oscarzhao Mar 15, 2017
c9f6511
implements driver.Pinger interface; add some comments for other function
oscarzhao Mar 16, 2017
543132c
add doc on context support
oscarzhao Mar 16, 2017
9b7ce2e
only apply to 1.8+
oscarzhao Mar 16, 2017
0f73f56
use build tag for different go versions
oscarzhao Mar 17, 2017
08e3647
rename files to reduce the diff size
oscarzhao Mar 17, 2017
4921cf5
move build tag to top of files
oscarzhao Mar 17, 2017
33b837a
Implements driver.Pinger interface
oscarzhao Mar 17, 2017
b270398
bugfix for implementing ConnBeginTx interface
oscarzhao Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ go:
- 1.5
- 1.6
- 1.7
- 1.8
- tip

before_script:
Expand Down
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,11 @@ Version 1.0 of the driver recommended adding `&charset=utf8` (alias for `SET NAM

See http://dev.mysql.com/doc/refman/5.7/en/charset-unicode.html for more details on MySQL's Unicode support.

## Context Support
Since go1.8, context is introduced to `database/sql` for better control on timeout and cancellation.
New interfaces such as `driver.QueryerContext`, `driver.ExecerContext` are introduced. See more details on [context support to database/sql package](https://golang.org/doc/go1.8#database_sql, "sql").

In Go-MySQL-Driver, we implemented these interfaces for structs `mysqlConn`, `mysqlStmt` and `mysqlTx`.

## Testing / Development
To run the driver tests you may need to adjust the configuration. See the [Testing Wiki-Page](https://github.com/go-sql-driver/mysql/wiki/Testing "Testing") for details.
Expand Down
2 changes: 2 additions & 0 deletions connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// +build !go1.8

// Go MySQL Driver - A MySQL-Driver for Go's database/sql package
//
// Copyright 2012 The Go-MySQL-Driver Authors. All rights reserved.
Expand Down
Loading