zero-copy buffer #55
Merged
zero-copy buffer #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No extra allocation when refilling the buffer Closes #52
| if err != nil { | ||
| errLog.Print(err.Error()) | ||
| return nil, driver.ErrBadConn | ||
| } | ||
|
|
||
| // Packet Length [24 bit] | ||
| pktLen := uint32(data[0]) | uint32(data[1])<<8 | uint32(data[2])<<16 |
There was a problem hiding this comment.
leave as is, cast to int in L54 readNext?
There was a problem hiding this comment.
What would be the benefit of that?
There was a problem hiding this comment.
honestly - none. Just one change less (and I dislike parens around long expressions)
ghost
assigned
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #52
This approach removes the 2nd buffer (date / packet buffer). Instead we work with slices directly from the buffer. This results in more or less zero copy.
Performance:
Before
After
I worked on such a "zero copy buffer" before but stopped when I found a reason why this concept couldn't work - at least I assumed it the be a reason.
Until now I found no case where the new buffer causes problems, but please test it as much as you can.
Especially cases where
sql.RawBytesis used excessively could be interesting.