Skip to content

doc: add requirements to Config field comments #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2016

Conversation

arnehormann
Copy link
Member

Description

Improve visibility of required fields in Config (the format is documented in README.md, but that's probably not where users of Config look first).

Checklist

  • Code compiles correctly
  • Created tests, if possible
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@arnehormann arnehormann mentioned this pull request Mar 1, 2016
5 tasks
@arnehormann arnehormann changed the title add requirements to Config field comments doc: add requirements to Config field comments Mar 1, 2016
@julienschmidt
Copy link
Member

LGTM, maybe put it in brackets instead

arnehormann added a commit that referenced this pull request Mar 1, 2016
doc: add requirements to Config field comments
@arnehormann arnehormann merged commit 44e7035 into go-sql-driver:master Mar 1, 2016
@arnehormann arnehormann deleted the doc-config-reqs branch March 1, 2016 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants