ensure cipher memory safety #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return cipher, nil | ||
| // make a memory safe copy of the cipher slice |
There was a problem hiding this comment.
"memory safe" - that's a weird comment.
What does it mean in this context; why copy, how could it be corrupted otherwise?
|
Doh... sorry, I'm tired. Ignore my comment, LGTM |
julienschmidt
added a commit
that referenced
this pull request
Dec 8, 2013
ensure cipher memory safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no second cipher part is received, the cipher can be overwritten since it is just a slice from the net buffer