add Marker #22
Open
add Marker #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proxy for golang/go#52751 until that lands. When it does, we should be able to make this API a wrapper around the stdlib API.
frankban
reviewed
Apr 11, 2025
| } | ||
|
|
||
| // Source returns the File and Line. | ||
| func (m Marker) Source() (string, int) { return m.File, m.Line } |
| Line int | ||
| } | ||
|
|
||
| // Mark returns a Marker with the given name |
There was a problem hiding this comment.
We could expand the docstring with an example of how to use this, as part of table testing for instance, by calling Mark there and then Run in the actual test.
| // A Marker records a name at a given Go source file position. | ||
| type Marker struct { | ||
| _ struct{} // Prevent | ||
| Name string |
There was a problem hiding this comment.
Can these be private fields?
|
|
||
| // A Marker records a name at a given Go source file position. | ||
| type Marker struct { | ||
| _ struct{} // Prevent |
There was a problem hiding this comment.
Prevent what? Building this without specifying the field names? If so, please expand the comment, and explain the reason?
| }) | ||
| f(b) | ||
| }) | ||
| } |
There was a problem hiding this comment.
I guess this might be tested similar to what we do in report_test.go, even if it is fragile, but probably worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proxy for golang/go#52751 until that lands. When it does, we should be able to make this API a wrapper around the stdlib API.
I'm not sure how best to test this, but I've tested it manually and the code is simple enough that
perhaps that's OK.