Skip to content

Add missing migrations for columns on repository and user #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2020

Conversation

guillep2k
Copy link
Member

Working in #9787 I've found that there are some columns in repository and user which have no migration step. For my PR I need these columns to exists before starting the main process, so I've created a migration step for them.

@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #9861 into master will decrease coverage by 0.03%.
The diff coverage is 16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9861      +/-   ##
==========================================
- Coverage    42.3%   42.27%   -0.04%     
==========================================
  Files         605      605              
  Lines       79151    79242      +91     
==========================================
+ Hits        33485    33497      +12     
- Misses      41540    41615      +75     
- Partials     4126     4130       +4
Impacted Files Coverage Δ
modules/graceful/server.go 48.55% <0%> (-3.8%) ⬇️
routers/repo/issue_dependency.go 0% <0%> (ø) ⬆️
routers/user/auth.go 11.44% <0%> (-0.59%) ⬇️
modules/setting/setting.go 45.09% <0%> (-0.44%) ⬇️
modules/context/repo.go 57.21% <100%> (ø) ⬆️
routers/repo/compare.go 40.44% <100%> (ø) ⬆️
modules/markup/sanitizer.go 85.71% <100%> (ø) ⬆️
routers/repo/issue.go 38.03% <58.33%> (-0.05%) ⬇️
routers/api/v1/repo/issue.go 53.8% <69.23%> (+0.39%) ⬆️
services/pull/check.go 54.54% <0%> (-2.1%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497856b...9598e86. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2020
@lunny
Copy link
Member

lunny commented Jan 19, 2020

The columns are not missing but migrations maybe missed.

@guillep2k guillep2k changed the title Add missing columns to repository and user Add missing migrations for columns on repository and user Jan 19, 2020
@guillep2k
Copy link
Member Author

The columns are not missing but migrations maybe missed.

Sorry, bad wording of the PR title. Changed.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2020
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 19, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 19, 2020
@6543
Copy link
Member

6543 commented Jan 19, 2020

think it can go in now

@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit bec9950 into go-gitea:master Jan 19, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants