Skip to content

Fix issues/pulls dependencies problems #9842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2020
Merged

Fix issues/pulls dependencies problems #9842

merged 3 commits into from
Jan 19, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 17, 2020

Fix #6039

@lunny lunny added this to the 1.12.0 milestone Jan 17, 2020
@lunny lunny force-pushed the lunny/fix_dependcies branch from 89057ab to 7da97e7 Compare January 17, 2020 16:19
@lunny
Copy link
Member Author

lunny commented Jan 17, 2020

I also found more problems about issue dependencies and will fix them on next PRs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 17, 2020
6543
6543 approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need make generate-swagger beside that ok

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 17, 2020
6543
6543 requested changes Jan 17, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make generate-swagger + rename filed + clarify description

6543
6543 reviewed Jan 17, 2020
View reviewed changes
@lunny lunny force-pushed the lunny/fix_dependcies branch from 7da97e7 to f1e36b1 Compare January 18, 2020 02:05
@lunny
Copy link
Member Author

lunny commented Jan 18, 2020

@silverwind @6543 done.

silverwind
silverwind reviewed Jan 18, 2020
View reviewed changes
@lunny lunny force-pushed the lunny/fix_dependcies branch from f1e36b1 to a7866b0 Compare January 19, 2020 05:11
guillep2k
guillep2k approved these changes Jan 19, 2020
View reviewed changes
templates/repo/issue/view_content/sidebar.tmpl
@@ -428,6 +428,7 @@
<input type="hidden" id="repolink" value="{{$.RepoRelPath}}">
<input type="hidden" id="repoId" value="{{.Repository.ID}}">
<input type="hidden" id="crossRepoSearch" value="{{.AllowCrossRepositoryDependencies}}">
<input type="hidden" id="type" value="{{.IssueType}}">
<!-- I know, there is probably a better way to do this -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant for this PR, but we should get rid of this comment or at least hide it from the rendered output:

Suggested change
<!-- I know, there is probably a better way to do this -->
{{/* I know, there is probably a better way to do this */}}

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #9842 into master will decrease coverage by <.01%.
The diff coverage is 47.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9842      +/-   ##
==========================================
- Coverage   42.31%   42.31%   -0.01%     
==========================================
  Files         604      604              
  Lines       79137    79155      +18     
==========================================
+ Hits        33490    33493       +3     
- Misses      41521    41533      +12     
- Partials     4126     4129       +3
Impacted Files Coverage Δ
routers/repo/issue_dependency.go 0% <0%> (ø) ⬆️
modules/context/repo.go 57.21% <100%> (ø) ⬆️
routers/repo/compare.go 40.44% <100%> (ø) ⬆️
routers/repo/issue.go 38.03% <58.33%> (-0.05%) ⬇️
routers/api/v1/repo/issue.go 53.8% <69.23%> (+0.39%) ⬆️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/check.go 56.64% <0%> (-2.1%) ⬇️
services/pull/patch.go 66.03% <0%> (-1.89%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
models/error.go 30.76% <0%> (-0.55%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0641965...a7866b0. Read the comment docs.

@lunny lunny merged commit f540d0a into go-gitea:master Jan 19, 2020
@lunny lunny deleted the lunny/fix_dependcies branch January 19, 2020 06:43
lunny added a commit to lunny/gitea that referenced this pull request Jan 19, 2020
@lunny
Fix issues/pulls dependencies problems (go-gitea#9842)
0a2216f 
* Fix issues/pulls dependencies problems

* fix swagger and api param name

* fix js
@lunny lunny mentioned this pull request Jan 19, 2020
Merged
techknowlogick pushed a commit that referenced this pull request Jan 19, 2020
@lunny @techknowlogick
Fix issues/pulls dependencies problems (#9842) (#9864)
8add1df 
* Fix issues/pulls dependencies problems

* fix swagger and api param name

* fix js
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jan 19, 2020
This was referenced Jan 20, 2020
Merged
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Pullrequest dependencies are disabled when internal issue tracker is disabled
7 participants
@lunny @codecov-io @silverwind @guillep2k @6543 @techknowlogick @GiteaBot