Skip to content

[refactor] notify remove unused praram #9804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2020
Merged

[refactor] notify remove unused praram #9804

merged 4 commits into from
Jan 16, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 16, 2020

as title

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 16, 2020
@sapk sapk added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 16, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ec6f832). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #9804   +/-   ##
========================================
  Coverage          ?   42.2%           
========================================
  Files             ?     603           
  Lines             ?   78863           
  Branches          ?       0           
========================================
  Hits              ?   33286           
  Misses            ?   41501           
  Partials          ?    4076
Impacted Files Coverage Δ
modules/migrations/github.go 78.73% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6f832...9e171e9. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2020
@sapk sapk merged commit 06cd3e0 into go-gitea:master Jan 16, 2020
@6543 6543 deleted the refactor-notify-mergePR-param branch January 16, 2020 17:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-io @zeripath @sapk @GiteaBot