-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
update supported browsers and add a few more #9734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
IE 11 and references to it removed as per discussion. I had to explicitely exclude it because it still came in the Also removed Safari 5.1. I think this is the long dead Windows version of Safari from 2011 which I would not expect to work. |
Is this selecting based on any official average statistics? I would prefer some standard statistics before dropping support for browsers in minor version changes. |
Maybe just stay to |
Browser usage data comes from caniuse data which I think is sourced from statcounter. |
I wouldn't. Either we support it or not. It will block certain features like CSS variable so I think it's time we do it. By the way GitHub dropped IE 11 support in July 2018, I say it's long overdue. |
Now includes Firefox ESR, Opera and a few more browser with usages between 0.5% and 1%. defaults resolves to > 0.5%, last 2 versions, Firefox ESR, not dead.
96c2816
to
22cc449
Compare
Decided to give IE11 a try and with #9735 applied, it actually does not look so bad, no JS errors while browsing a few pages. Based on that, I think It does not noticeable increase build size (only about 1kB more CSS, JS stays the same). |
Codecov Report
@@ Coverage Diff @@
## master #9734 +/- ##
=========================================
Coverage ? 42.18%
=========================================
Files ? 603
Lines ? 78837
Branches ? 0
=========================================
Hits ? 33256
Misses ? 41509
Partials ? 4072
Continue to review full report at Codecov.
|
Now includes Firefox ESR, Opera and a few more browser with usages between 0.5% and 1%. defaults resolves to > 0.5%, last 2 versions, Firefox ESR, not dead.
before
and_chr 78
and_uc 12.12
chrome 79
chrome 78
edge 18
firefox 71
firefox 70
ie 11
ios_saf 13.3
ios_saf 13.2
ios_saf 13.0-13.1
ios_saf 12.2-12.4
op_mini all
safari 13
safari 12.1
samsung 10.1
after
and_chr 78
and_ff 68
and_qq 1.2
and_uc 12.12
android 76
baidu 7.12
chrome 79
chrome 78
chrome 77
chrome 49
edge 18
edge 17
firefox 71
firefox 70
firefox 68
ie 11
ie_mob 11
ios_saf 13.3
ios_saf 13.2
ios_saf 13.0-13.1
ios_saf 12.2-12.4
kaios 2.5
op_mini all
op_mob 46
opera 64
opera 63
safari 13
safari 12.1
safari 5.1
samsung 10.1
samsung 9.2