Skip to content

update supported browsers and add a few more #9734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 16, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jan 12, 2020

Now includes Firefox ESR, Opera and a few more browser with usages between 0.5% and 1%. defaults resolves to > 0.5%, last 2 versions, Firefox ESR, not dead.

before

and_chr 78
and_uc 12.12
chrome 79
chrome 78
edge 18
firefox 71
firefox 70
ie 11
ios_saf 13.3
ios_saf 13.2
ios_saf 13.0-13.1
ios_saf 12.2-12.4
op_mini all
safari 13
safari 12.1
samsung 10.1

after

and_chr 78
and_ff 68
and_qq 1.2
and_uc 12.12
android 76
baidu 7.12
chrome 79
chrome 78
chrome 77
chrome 49
edge 18
edge 17
firefox 71
firefox 70
firefox 68
ie 11
ie_mob 11
ios_saf 13.3
ios_saf 13.2
ios_saf 13.0-13.1
ios_saf 12.2-12.4
kaios 2.5
op_mini all
op_mob 46
opera 64
opera 63
safari 13
safari 12.1
safari 5.1
samsung 10.1
samsung 9.2

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 12, 2020
@silverwind silverwind changed the title update supported browsers to include a few more update supported browsers, remove IE11, add a few more Jan 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2020
@silverwind
Copy link
Member Author

silverwind commented Jan 12, 2020

IE 11 and references to it removed as per discussion. I had to explicitely exclude it because it still came in the defaults.

Also removed Safari 5.1. I think this is the long dead Windows version of Safari from 2011 which I would not expect to work.

@tboerger
Copy link
Member

Is this selecting based on any official average statistics? I would prefer some standard statistics before dropping support for browsers in minor version changes.

@sapk
Copy link
Member

sapk commented Jan 12, 2020

Maybe just stay to defaults even if it contain IE11 ?

@silverwind
Copy link
Member Author

silverwind commented Jan 12, 2020

Browser usage data comes from caniuse data which I think is sourced from statcounter.

@silverwind
Copy link
Member Author

Maybe just stay to defaults even if it contain IE11 ?

I wouldn't. Either we support it or not. It will block certain features like CSS variable so I think it's time we do it.

By the way GitHub dropped IE 11 support in July 2018, I say it's long overdue.

@silverwind silverwind changed the title update supported browsers, remove IE11, add a few more update supported browsers and add a few more Jan 12, 2020
Now includes Firefox ESR, Opera and a few more browser with usages
between 0.5% and 1%. defaults resolves to > 0.5%, last 2 versions, Firefox ESR, not dead.
@silverwind
Copy link
Member Author

Decided to give IE11 a try and with #9735 applied, it actually does not look so bad, no JS errors while browsing a few pages.

Based on that, I think defaults is good enough for now, so IE support lives on.

It does not noticeable increase build size (only about 1kB more CSS, JS stays the same).

@sapk sapk added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 13, 2020
@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f106b09). Click here to learn what that means.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9734   +/-   ##
=========================================
  Coverage          ?   42.18%           
=========================================
  Files             ?      603           
  Lines             ?    78837           
  Branches          ?        0           
=========================================
  Hits              ?    33256           
  Misses            ?    41509           
  Partials          ?     4072
Impacted Files Coverage Δ
routers/repo/setting.go 13.44% <0%> (ø)
routers/routes/routes.go 86.51% <100%> (ø)
modules/sync/unique_queue.go 53.7% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f106b09...7bf1b36. Read the comment docs.

@sapk sapk merged commit 8716752 into go-gitea:master Jan 16, 2020
@silverwind silverwind deleted the update-browserslist branch January 16, 2020 09:54
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants