Skip to content

Load milestone in API PR list #9671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 10, 2020
Merged

Load milestone in API PR list #9671

merged 6 commits into from
Jan 10, 2020

Conversation

jolheiser
Copy link
Member

Issues uses a different IssueList struct that loads the milestone, but PRs don't ever load the Issue milestone through apiFormat

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 9, 2020
@codecov-io
Copy link

codecov-io commented Jan 9, 2020 •
edited
Loading

Codecov Report

Merging #9671 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9671      +/-   ##
==========================================
- Coverage   42.25%   42.24%   -0.01%     
==========================================
  Files         590      590              
  Lines       78002    78002              
==========================================
- Hits        32958    32955       -3     
- Misses      41000    41005       +5     
+ Partials     4044     4042       -2
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/queue/workerpool.go 39.91% <0%> (-1.29%) ⬇️
models/webhook.go 69.39% <0%> (-1.07%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5de6e42...c2c1c0c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2020
@lafriks lafriks added this to the 1.12.0 milestone Jan 9, 2020
@techknowlogick techknowlogick merged commit 480ef9d into go-gitea:master Jan 10, 2020
@techknowlogick
Copy link
Member

@jolheiser please send backport :)

@jolheiser jolheiser deleted the load_milestone branch January 10, 2020 21:20
jolheiser added a commit to jolheiser/gitea that referenced this pull request Jan 11, 2020
@jolheiser @lafriks
@lunny @techknowlogick
Load milestone in API PR list (go-gitea#9671)
1ccc025 
* Load milestone for Issue API format

Signed-off-by: jolheiser <[email protected]>

* Move further down

Signed-off-by: jolheiser <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@jolheiser jolheiser mentioned this pull request Jan 11, 2020
Merged
techknowlogick pushed a commit that referenced this pull request Jan 11, 2020
@jolheiser @techknowlogick
Load milestone in API PR list (#9671) (#9700)
a516a7b
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jan 11, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jolheiser @codecov-io @techknowlogick @lafriks @6543 @lunny @GiteaBot