Skip to content

Move newbranch to standalone package #9627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 14, 2020
Merged

Move newbranch to standalone package #9627

merged 10 commits into from
Jan 14, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 7, 2020

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 7, 2020
guillep2k
guillep2k reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunny can you fix the conflicts?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 8, 2020
@lunny
Copy link
Member Author

lunny commented Jan 9, 2020 •
edited
Loading

blocked by #9664

@lunny lunny force-pushed the lunny/move_newbranch branch from 46d0c5b to 23d3e9a Compare January 10, 2020 07:58
@lunny
Copy link
Member Author

lunny commented Jan 10, 2020

@guillep2k done.

guillep2k
guillep2k approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just resolve the latest conflict)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2020
@lunny lunny force-pushed the lunny/move_newbranch branch from f983740 to 190fe6b Compare January 10, 2020 15:42
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2020
@lunny lunny force-pushed the lunny/move_newbranch branch from 9be85aa to 7c519cb Compare January 11, 2020 12:11
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f99c3e4). Click here to learn what that means.
The diff coverage is 46.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9627   +/-   ##
=========================================
  Coverage          ?   42.29%           
=========================================
  Files             ?      599           
  Lines             ?    78324           
  Branches          ?        0           
=========================================
  Hits              ?    33128           
  Misses            ?    41142           
  Partials          ?     4054
Impacted Files Coverage Δ
modules/auth/admin.go 0% <ø> (ø)
models/migrations/migrations.go 1.3% <ø> (ø)
models/repo_generate.go 10.41% <ø> (ø)
modules/repository/repo.go 26.28% <0%> (ø)
routers/admin/orgs.go 0% <0%> (ø)
models/lfs.go 17.27% <0%> (ø)
modules/migrations/gitea.go 7.96% <0%> (ø)
routers/admin/users.go 28.69% <0%> (ø)
services/mirror/mirror.go 18.75% <0%> (ø)
models/migrations/v121.go 0% <0%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99c3e4...1310a1b. Read the comment docs.

@lunny lunny merged commit 2677d07 into go-gitea:master Jan 14, 2020
@lunny lunny deleted the lunny/move_newbranch branch January 14, 2020 03:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @guillep2k @6543 @GiteaBot