Skip to content

Add some padding to the shadowed comment box #9612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 5, 2020

Add a small amount of padding (4px) to the highlighted comment box - thus preventing the shadow from looking to crowded.

Previously:

box-shadow

Now:

box-shadow-fixed

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jan 5, 2020
@zeripath zeripath added this to the 1.11.0 milestone Jan 5, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 5, 2020
@codecov-io
Copy link

codecov-io commented Jan 5, 2020

Codecov Report

Merging #9612 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9612      +/-   ##
==========================================
- Coverage   42.17%   42.17%   -0.01%     
==========================================
  Files         578      578              
  Lines       76066    76070       +4     
==========================================
  Hits        32083    32083              
- Misses      40004    40008       +4     
  Partials     3979     3979
Impacted Files Coverage Δ
models/repo_list.go 74.42% <100%> (+0.35%) ⬆️
routers/home.go 46.87% <100%> (+0.18%) ⬆️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
models/gpg_key.go 55.59% <0%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adc504...e32a180. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 5, 2020
@zeripath zeripath merged commit 2a1cf5b into go-gitea:master Jan 5, 2020
@zeripath zeripath deleted the fix-comment-box-shaddow-padding branch January 5, 2020 19:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants