Skip to content

Attempt to fix release-master not including js/css #9316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Member

My assumption currently is that drone pipeline steps may not share files so files generated in the previous 'build' tasks may have been discarded for the previous 'static' task.

My assumption currently is that drone pipeline steps may not share files
so files generated in the previous 'build' tasks may have been discarded
for the previous 'static' task.
@silverwind
Copy link
Member Author

I think this can only really be tested once it has landed and the release-master pipeline runs with it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 10, 2019
@lafriks
Copy link
Member

lafriks commented Dec 10, 2019

No, files are shared in same pipeline

@codecov-io
Copy link

Codecov Report

Merging #9316 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9316      +/-   ##
==========================================
+ Coverage   41.18%   41.19%   +<.01%     
==========================================
  Files         559      559              
  Lines       73115    73115              
==========================================
+ Hits        30114    30120       +6     
+ Misses      39225    39218       -7     
- Partials     3776     3777       +1
Impacted Files Coverage Δ
routers/repo/view.go 39.47% <0%> (+0.87%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50da9f7...b08f3f8. Read the comment docs.

@silverwind
Copy link
Member Author

silverwind commented Dec 10, 2019

@lafriks Your're probably right. Drone documentation says files should persist between steps. I'm a bit out of ideas. release-master steps do run fine:

https://drone.gitea.io/go-gitea/gitea/17228/3/3
https://drone.gitea.io/go-gitea/gitea/17228/3/4

Still, the release binaries at https://dl.gitea.io/gitea/master/ seem to redirect to /install instead of serving js/css files. Maybe @techknowlogick has a better idea.

@silverwind
Copy link
Member Author

Probably not the right solution

@silverwind silverwind closed this Dec 10, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants