Skip to content

Fix Issues/PR List "in your repository" view #9238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

jolheiser
Copy link
Member

This PR correctly sets the viewType so that "in your repositories" is active when applicable.
Ignore the incorrect counts in the above screenshot, that's being taken care of in another PR.

viewType doesn't drive any logic other than the template, so no queries are affected.
Screenshot from 2019-12-02 21-47-29
Screenshot from 2019-12-02 21-47-45

Signed-off-by: jolheiser <[email protected]>
@lunny
Copy link
Member

lunny commented Dec 3, 2019

So this is a break change?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 3, 2019
@jolheiser
Copy link
Member Author

@lunny It shouldn't be that I know of. Ultimately it's a UI fix.

@codecov-io
Copy link

Codecov Report

Merging #9238 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9238      +/-   ##
=========================================
+ Coverage   41.08%   41.1%   +0.01%     
=========================================
  Files         555     555              
  Lines       72393   72393              
=========================================
+ Hits        29746   29756      +10     
+ Misses      38901   38892       -9     
+ Partials     3746    3745       -1
Impacted Files Coverage Δ
routers/user/home.go 59.91% <66.66%> (+0.22%) ⬆️
modules/task/migrate.go 25% <0%> (-3.95%) ⬇️
models/error.go 32.67% <0%> (-1.19%) ⬇️
models/repo.go 47.87% <0%> (+0.05%) ⬆️
modules/migrations/gitea.go 9.45% <0%> (+0.63%) ⬆️
models/repo_list.go 74.07% <0%> (+0.92%) ⬆️
modules/migrations/migrate.go 25.4% <0%> (+1.62%) ⬆️
models/repo_indexer.go 67.74% <0%> (+1.79%) ⬆️
modules/indexer/indexer.go 55.26% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ef9ff...f67b605. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 3, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2019
@lunny lunny merged commit e459f99 into go-gitea:master Dec 3, 2019
@lafriks lafriks added this to the 1.11.0 milestone Dec 3, 2019
@jolheiser jolheiser deleted the fix_issues_all branch December 3, 2019 14:34
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants