Skip to content

Fix Dashboard Issues/PR list #9235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 3, 2019

No description provided.

@techknowlogick techknowlogick added this to the 1.11.0 milestone Dec 3, 2019
@6543 6543 changed the title Fix Issue-dashborard [WIP] Fix Issue-dashborard Dec 3, 2019
@6543 6543 changed the title [WIP] Fix Issue-dashborard Fix Dashborard Issue List (same number of items at each page) Dec 3, 2019
@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #9235 into master will increase coverage by 0.01%.
The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9235      +/-   ##
=========================================
+ Coverage   41.08%   41.1%   +0.01%     
=========================================
  Files         555     555              
  Lines       72393   72400       +7     
=========================================
+ Hits        29745   29757      +12     
+ Misses      38904   38903       -1     
+ Partials     3744    3740       -4
Impacted Files Coverage Δ
routers/user/home.go 60.52% <54.16%> (+0.61%) ⬆️
modules/indexer/indexer.go 44.73% <0%> (-10.53%) ⬇️
models/pull.go 55.13% <0%> (-0.44%) ⬇️
models/gpg_key.go 55.59% <0%> (+0.55%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
models/repo_indexer.go 67.74% <0%> (+1.79%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e459f99...282790d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 3, 2019
@6543 6543 changed the title Fix Dashborard Issue List (same number of items at each page) [Dont Merge] Fix Dashborard Issue List (same number of items at each page) Dec 3, 2019
@6543 6543 changed the title [Dont Merge] Fix Dashborard Issue List (same number of items at each page) [Pleace Rename] Fix Dashborard Issue List (same number of items at each page) Dec 3, 2019
@jolheiser
Copy link
Member

As far as I can tell this fixes the problem.
Proposed title Fix Dashboard Issues/PR list.
This is only present in master so I don't think it needs much more context.

@6543 6543 changed the title [Pleace Rename] Fix Dashborard Issue List (same number of items at each page) Fix Dashboard Issues/PR list Dec 3, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 3, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2019
@lafriks lafriks merged commit e43de0d into go-gitea:master Dec 3, 2019
@6543 6543 deleted the fix-issue-dashboard branch January 22, 2020 09:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants