Skip to content

Move notifywatchers from models to notification #8907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2019
Merged

Move notifywatchers from models to notification #8907

merged 3 commits into from
Nov 11, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 10, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 10, 2019
@codecov-io
Copy link

codecov-io commented Nov 10, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0e28138). Click here to learn what that means.
The diff coverage is 72.72%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #8907   +/-   ##
========================================
  Coverage          ?   41.3%           
========================================
  Files             ?     545           
  Lines             ?   70388           
  Branches          ?       0           
========================================
  Hits              ?   29071           
  Misses            ?   37620           
  Partials          ?    3697
Impacted Files Coverage Δ
models/repo.go 49.01% <ø> (ø)
modules/notification/action/action.go 58.33% <72.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e28138...21ce3a2. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 10, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 10, 2019
@lunny lunny merged commit 273a24f into go-gitea:master Nov 11, 2019
@lunny lunny deleted the lunny/move_actions branch November 11, 2019 03:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @zeripath @guillep2k @GiteaBot