Skip to content

FIX download diff/patch from commit #8792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 2, 2019
Merged

FIX download diff/patch from commit #8792

merged 6 commits into from
Nov 2, 2019

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 2, 2019

close #8791

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 2, 2019
@6543
Copy link
Member Author

6543 commented Nov 2, 2019

@jaqra can you review ;) You discovered the bug

@lafriks lafriks added this to the 1.11.0 milestone Nov 2, 2019
@6543
Copy link
Member Author

6543 commented Nov 2, 2019 •
edited
Loading

@lafriks can you restart CI?
and maby look at it?

@techknowlogick
Copy link
Member

Restarted

@codecov-io
Copy link

codecov-io commented Nov 2, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@729708e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8792   +/-   ##
=========================================
  Coverage          ?   41.23%           
=========================================
  Files             ?      542           
  Lines             ?    69708           
  Branches          ?        0           
=========================================
  Hits              ?    28747           
  Misses            ?    37277           
  Partials          ?     3684

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729708e...0c3cc21. Read the comment docs.

@6543 6543 requested a review from mrsdizzie November 2, 2019 21:25
@6543
Copy link
Member Author

6543 commented Nov 2, 2019

@mrsdizzie done

@6543 6543 changed the title FIX downloa diff/patch from commit FIX download diff/patch from commit Nov 2, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2019
@techknowlogick techknowlogick merged commit 76185ed into go-gitea:master Nov 2, 2019
@techknowlogick
Copy link
Member

Does this need backporting to 1.10?

@6543 6543 deleted the fix_8791_diff-download-on-commit branch November 2, 2019 22:48
@6543
Copy link
Member Author

6543 commented Nov 2, 2019

@techknowlogick no this template change was made after 1.10.x

@techknowlogick
Copy link
Member

Sounds good. Thanks :)

@zeripath zeripath mentioned this pull request Nov 21, 2019
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@kolaente kolaente kolaente approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Diff Options -> Download Patch/Diff File is not work
7 participants
@6543 @techknowlogick @codecov-io @mrsdizzie @kolaente @lafriks @GiteaBot