Doc updated list of supported webhooks and added example #8388
Conversation
| } | ||
|
|
||
| // check authorization | ||
| if ($decoded['secret'] != $secret_key) { |
There was a problem hiding this comment.
You shouldn't rely on this field existing, it is currently deprecated as we are migrating towards using the checksum header to validate hook content. Would you be able to update this?
There was a problem hiding this comment.
I didn't know and I actually just learnt about it from you. How does the new system work? Is there any doc about it yet?
There was a problem hiding this comment.
Yes, this https://togithub.com/gogs/gogs/issues/4233 and this #3901 should provide details you are looking for :)
There was a problem hiding this comment.
interesting indeed, let me check that and make changes to the script
There was a problem hiding this comment.
@techknowlogick I've updated the code snippet and tested it. It works. I hope that's what you had in mind.
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #8388 +/- ##
=========================================
Coverage ? 41.79%
=========================================
Files ? 497
Lines ? 65639
Branches ? 0
=========================================
Hits ? 27436
Misses ? 34685
Partials ? 3518Continue to review full report at Codecov.
|
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
The list of supported webhooks was not up-to-date and I added an example of how to receive the hook.