-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add 'make prepare-tools' for offline builds #8011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that the OpenSUSE build service gets the build prerequisites for a package by a declarative description/configuration. So, this PR probably does not help at all. The users of UBS can handle this on their side without help from Gitea. |
Codecov Report
@@ Coverage Diff @@
## master #8011 +/- ##
==========================================
- Coverage 41.6% 41.59% -0.01%
==========================================
Files 479 479
Lines 64106 64106
==========================================
- Hits 26670 26667 -3
- Misses 33980 33981 +1
- Partials 3456 3458 +2
Continue to review full report at Codecov.
|
@@ -471,8 +438,14 @@ pr: | |||
|
|||
.PHONY: golangci-lint | |||
golangci-lint: | |||
@hash golangci-lint > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can keep those checks but call make prepare-tools
if needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean check the tools at the call sites or check them under prepare-tools
?
Decide what we can help in the future when people complain about it. 😉 |
Add a new make target
make prepare-tools
that install all the needed tools for us.Not sure if this is actually better or helpful at all for use cases like #7997.