Skip to content

Add 'make prepare-tools' for offline builds #8011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

typeless
Copy link
Contributor

Add a new make target make prepare-tools that install all the needed tools for us.
Not sure if this is actually better or helpful at all for use cases like #7997.

@typeless
Copy link
Contributor Author

It seems that the OpenSUSE build service gets the build prerequisites for a package by a declarative description/configuration. So, this PR probably does not help at all. The users of UBS can handle this on their side without help from Gitea.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #8011 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8011      +/-   ##
==========================================
- Coverage    41.6%   41.59%   -0.01%     
==========================================
  Files         479      479              
  Lines       64106    64106              
==========================================
- Hits        26670    26667       -3     
- Misses      33980    33981       +1     
- Partials     3456     3458       +2
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 73.17% <0%> (-0.98%) ⬇️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256b178...e8da8f6. Read the comment docs.

@@ -471,8 +438,14 @@ pr:

.PHONY: golangci-lint
golangci-lint:
@hash golangci-lint > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can keep those checks but call make prepare-tools if needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean check the tools at the call sites or check them under prepare-tools?

@typeless
Copy link
Contributor Author

typeless commented Aug 28, 2019

Decide what we can help in the future when people complain about it. 😉

@typeless typeless closed this Aug 28, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants