-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Avoid make-generate downloading packages from the internet #8008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
~~ Also, I assume the |
I think we have |
@lunny yes, but after trying to What baffles me right now is that I cannot reproduce the CI error at my local machine. |
ad1ee1e
to
65d675d
Compare
We still have other dependencies which require downloads such as the swagger tool. |
@typeless and current go-swagger version require to be in GOPATH which hold us to move to a real mod workflow. |
Codecov Report
@@ Coverage Diff @@
## master #8008 +/- ##
==========================================
- Coverage 41.6% 41.59% -0.01%
==========================================
Files 479 479
Lines 64106 64106
==========================================
- Hits 26669 26665 -4
- Misses 33979 33984 +5
+ Partials 3458 3457 -1
Continue to review full report at Codecov.
|
Fixes #7997